Multiauth #3
Open
Multiauth #3
+1,142
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
* Fixing guidebook not resizable from left and right issue 34504 in space-wizards/space-station-14 needs this fix * update fix guideBood not resizable a safer and more error resistent solution to space-wizards/space-station-14#34504 * Mask DragMode.Move --------- Co-authored-by: ElectroJr <[email protected]>
…redTree already was called with _currentPrototype empty (#5649) Co-authored-by: pa.pecherskij <[email protected]>
Apparently it can clip and the buffer is really just there so we despawn 'at some point' and rather than hunching over my debugger for potentially an hour this is easier and almost no impact. I've also considered flagging some audio as "play the full thing" if someone misses the start of it but need to thonk on that one a bit in future.
* Add another lookup overload * Fix RenderInRenderTarget See the linked issue for what happens. * Also this one * stuff * Fix stencilling * fixes * mix blend * fix * blur fixes * Tile flag * Minor tweak * Fixes * Render state fixes * Fixes * Fix stupidity * More state render bug fixes * MapUid on overlay draw * Remove blur comment * Fixes * Fixes * Remove * Engine vibe
There was a problem hiding this comment.
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Robust.Client/Graphics/Clyde/Clyde.Rendering.cs:420
- When disabling the scissor test, a call to CheckGlError() is omitted. For consistent error checking and debugging, consider invoking CheckGlError() after disabling the state.
else { GL.Disable(EnableCap.ScissorTest); }
Comment on lines
82
to
86
| var userId = Guid.Parse(reader.GetString(0)); | ||
| var userName = reader.GetString(1); | ||
| var token = reader.GetString(2); | ||
| serverUrl = reader.GetString(4); | ||
|
|
There was a problem hiding this comment.
Hardcoding the column index when retrieving the serverUrl makes the code fragile if the query order ever changes. Consider using named columns or defined constants to ensure the correct value is extracted even if the SQL query is updated.
Suggested change
| var userId = Guid.Parse(reader.GetString(0)); | |
| var userName = reader.GetString(1); | |
| var token = reader.GetString(2); | |
| serverUrl = reader.GetString(4); | |
| var userId = Guid.Parse(reader.GetString(reader.GetOrdinal("UserId"))); | |
| var userName = reader.GetString(reader.GetOrdinal("UserName")); | |
| var token = reader.GetString(reader.GetOrdinal("Token")); | |
| serverUrl = reader.GetString(reader.GetOrdinal("ServerUrl")); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.